jamesnetherton commented on code in PR #9132:
URL: https://github.com/apache/camel-quarkus/pull/9132#discussion_r3955655516
##########
extensions/ai-tool/deployment/pom.xml:
##########
@@ -38,6 +38,10 @@
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-ai-tool</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
Review Comment:
Agreed, and confirmed the reasoning end to end: `camel-ai-tool` pulls only
`camel-support`, the `ObjectMapper` is used solely in
`CamelAiToolProvider.parseArguments()`, that bean is registered only when
Quarkus LangChain4j is present, and `quarkus-langchain4j-core` declares a
non-optional `quarkus-jackson`.
Fixed in 50a5464: `quarkus-jackson` is now `<optional>true</optional>` in
the runtime pom and `quarkus-jackson-deployment` is dropped from the deployment
pom. Verified with `integration-tests/ai-tool` (no Quarkus LangChain4j, so
Jackson genuinely absent) in both JVM and native mode, 12/12 each. Also checked
`integration-tests/mcp-server`, the other module depending on
`camel-quarkus-ai-tool` without declaring Jackson itself — it gets
`quarkus-jackson` from `quarkus-mcp-server`, so it is unaffected.
*This review was generated by an AI agent and may contain inaccuracies.
Please verify all suggestions before applying.*
*Claude Code on behalf of James Netherton*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
