jamesnetherton commented on PR #9132: URL: https://github.com/apache/camel-quarkus/pull/9132#issuecomment-5581470075
Thanks for the review — all three points are addressed in 50a5464, along with the CI failure. **On `@CamelAiTools` without Quarkus LangChain4j:** the premise isn't quite right, so noting it for the record. The old warning lived in `validateAndRegisterAiServices` inside a class annotated `@BuildSteps(onlyIf = QuarkusLangchain4jPresent.class)` (line 86 of the pre-PR `SupportQuarkusLangchain4jProcessor`), so without Quarkus LangChain4j there was no diagnostic before this PR either. Nothing regressed there. The gap you're pointing at is real, though, and it is cheap to close now that `@CamelAiTools` lives in this extension. Diagnostics moved into a `validateCamelAiToolsUsage` step with **no** `onlyIf` gate — gating on the very things that may be missing is what silenced the report — so: * `@CamelAiTools` without Quarkus LangChain4j now warns that the annotation has no effect * the existing "`camel-langchain4j-agent` missing" warning still fires as before * `registerCamelAiToolProvider` is reduced to just registering the bean **Separately, the CI failure** was a genuine regression from this PR: moving the bridge into `camel-quarkus-ai-tool` means it is registered only when that extension is a dependency, and `integration-tests/langchain4j-agent-ql4j` was relying on getting it transitively via `camel-quarkus-support-langchain4j`. It silently lost its Camel tools, so the request went out with `"tools": []` and WireMock rejected it. The module now declares `camel-quarkus-ai-tool` (which it should, since it uses `ai-tool:` routes directly), and a startup warning names the affected tools when tools are registered without the bridge, so this cannot fail silently again. The migration note is corrected accordingly. **Verification:** `ai-tool` and `langchain4j-agent-ql4j` pass in both JVM and native mode; `ai-tool-langchain4j`, `langchain4j-agent`, `langchain4j-agent-bean-binding-ql4j` and `mcp-server` pass in JVM mode; full reactor `clean install -Dquickly` is green. The startup warning was confirmed firing from a native binary by temporarily removing the dependency again. *This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.* *Claude Code on behalf of James Netherton* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
