gnodet-bot commented on code in PR #27539: URL: https://github.com/apache/camel/pull/27539#discussion_r4215941761
########## dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/commands/RunPropOptionTest.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.dsl.jbang.core.commands; + +import org.junit.jupiter.api.Test; +import picocli.CommandLine; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * CAMEL-25437: --prop takes its value after a space too, as every other option does, instead of losing it to the files + * to run. + */ +class RunPropOptionTest { + + @Test + void aPropertyAfterASpace() { + Run run = new Run(new CamelJBangMain()); + new CommandLine(run).parseArgs("route.camel.yaml", "--prop", "greeting=Hi"); + Review Comment: 💡 `run.files` is a package-private field accessed directly in the test. This couples the test to `Run`'s internal picocli `FilesConsumer` — works fine here since the test is in the same package, just worth noting if the field ever becomes private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
