gnodet-bot commented on code in PR #29093:
URL: https://github.com/apache/camel/pull/29093#discussion_r4455599946
##########
core/camel-core-model/src/main/java/org/apache/camel/model/dataformat/PQCDataFormat.java:
##########
@@ -47,8 +47,8 @@ public class PQCDataFormat extends DataFormatDefinition {
+ " SEED and SM4 are encrypted with GCM, and
CHACHA7539 with ChaCha20-Poly1305.")
private String symmetricKeyAlgorithm;
@XmlAttribute
- @Metadata(javaType = "java.lang.Integer", defaultValue = "128",
- description = "The length (in bits) of the symmetric key.")
+ @Metadata(javaType = "java.lang.Integer", defaultValue = "256",
+ description = "The length (in bits) of the symmetric key. SEED
and SM4 only accept 128.")
Review Comment:
The `@Metadata` description drives all generated catalog/JSON/XSD/YAML
schema outputs. The `.adoc` table correctly adds "GOST3412-2015 only 256" (and
CHACHA7539 is also 256-only, per the data format's allowed-algorithm set), but
none of the generated descriptors mention the 256-only constraint — users
relying on IDE autocompletion or schema tooling won't see it.
```suggestion
@Metadata(javaType = "java.lang.Integer", defaultValue = "256",
description = "The length (in bits) of the symmetric key. SEED
and SM4 only accept 128; GOST3412-2015 and CHACHA7539 only accept 256.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
