oscerd commented on code in PR #29093:
URL: https://github.com/apache/camel/pull/29093#discussion_r4470925840
##########
components/camel-pqc/src/main/java/org/apache/camel/component/pqc/PQCConfiguration.java:
##########
@@ -223,7 +223,8 @@ public int getSymmetricKeyLength() {
}
/**
- * The required length of the symmetric key used
+ * The required length of the symmetric key used. The default of 256 keeps
the strength of the shared secret the KEM
+ * produces; the fixed-size ciphers, such as SEED and SM4, only accept 128.
Review Comment:
Applied in 957275d19035 (`CAMEL-26548: Address review feedback - name the
256-only ciphers in the symmetricKeyLength description on both sides`): the
Javadoc now ends with "the fixed-size ciphers, such as SEED and SM4, only
accept 128, and GOST3412-2015 and CHACHA7539 only accept 256", with the
algorithm spelled as in the data format table and the upgrade guide. The
component JSON, the catalog mirror and the component and endpoint DSL factories
are regenerated from it with a full reactor build.
_Claude Code on behalf of oscerd_
##########
components/camel-pqc/src/main/java/org/apache/camel/component/pqc/PQCConfiguration.java:
##########
@@ -223,7 +223,8 @@ public int getSymmetricKeyLength() {
}
/**
- * The required length of the symmetric key used
+ * The required length of the symmetric key used. The default of 256 keeps
the strength of the shared secret the KEM
+ * produces; the fixed-size ciphers, such as SEED and SM4, only accept 128.
Review Comment:
Applied in 957275d19035 (`CAMEL-26548: Address review feedback - name the
256-only ciphers in the symmetricKeyLength description on both sides`): the
Javadoc now ends with "the fixed-size ciphers, such as SEED and SM4, only
accept 128, and GOST3412-2015 and CHACHA7539 only accept 256", with the
algorithm spelled as in the data format table and the upgrade guide. The
component JSON, the catalog mirror and the component and endpoint DSL factories
are regenerated from it with a full reactor build.
_Claude Code on behalf of oscerd_
##########
components/camel-pqc/src/main/docs/pqc-dataformat.adoc:
##########
@@ -127,8 +127,8 @@ YAML::
|symmetricKeyLength
|int
-|128
-|Length of the symmetric key in bits (128, 192, or 256 for AES)
+|256
+|Length of the symmetric key in bits (128, 192 or 256 for AES). SEED and SM4
only accept 128, and GOST3412-2015 only 256
Review Comment:
Applied in 957275d19035 (`CAMEL-26548: Address review feedback - name the
256-only ciphers in the symmetricKeyLength description on both sides`): the
table now reads "SEED and SM4 only accept 128; GOST3412-2015 and CHACHA7539
only accept 256", and the catalog mirror of the page is regenerated.
_Claude Code on behalf of oscerd_
##########
components/camel-pqc/src/main/docs/pqc-dataformat.adoc:
##########
@@ -127,8 +127,8 @@ YAML::
|symmetricKeyLength
|int
-|128
-|Length of the symmetric key in bits (128, 192, or 256 for AES)
+|256
Review Comment:
Applied in 957275d19035 (`CAMEL-26548: Address review feedback - name the
256-only ciphers in the symmetricKeyLength description on both sides`): the
table now reads "SEED and SM4 only accept 128; GOST3412-2015 and CHACHA7539
only accept 256", and the catalog mirror of the page is regenerated.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
