oscerd commented on code in PR #29093:
URL: https://github.com/apache/camel/pull/29093#discussion_r4466603189
##########
core/camel-core-model/src/main/java/org/apache/camel/model/dataformat/PQCDataFormat.java:
##########
@@ -47,8 +47,8 @@ public class PQCDataFormat extends DataFormatDefinition {
+ " SEED and SM4 are encrypted with GCM, and
CHACHA7539 with ChaCha20-Poly1305.")
private String symmetricKeyAlgorithm;
@XmlAttribute
- @Metadata(javaType = "java.lang.Integer", defaultValue = "128",
- description = "The length (in bits) of the symmetric key.")
+ @Metadata(javaType = "java.lang.Integer", defaultValue = "256",
+ description = "The length (in bits) of the symmetric key. SEED
and SM4 only accept 128.")
Review Comment:
Applied in 87a85ef, with the wording adjusted to `GOST3412_2015` (the enum
spelling used elsewhere in this description) rather than `GOST3412-2015`.
I checked the claim before taking it: against `VALID_SYMMETRIC_KEY_LENGTHS`
in `PQCProducer`, within the set the data format actually accepts (`AES`,
`ARIA`, `CAMELLIA`, `CAST6`, `DSTU7624`, `GOST3412-2015`, `SEED`, `SM4` plus
`CHACHA7539`), `GOST3412_2015` and `CHACHA7539` are indeed 256-only and
`SEED`/`SM4` 128-only. So the suggestion is right.
Regenerated across the model JSON, the component data-format JSON, the
catalog copies, the YAML DSL schemas and `ModelDeserializers`.
_Claude Code on behalf of @oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
