gnodet-bot commented on code in PR #29469:
URL: https://github.com/apache/camel/pull/29469#discussion_r4512340341
##########
.github/workflows/pr-ci-scripts-validation.yml:
##########
@@ -65,3 +65,11 @@ jobs:
run: |
cd .github/actions/incremental-build
uv run --with defusedxml python3 -m unittest discover --verbose
+
+ - name: Test the incremental build shell scripts
+ shell: bash
+ run: |
+ cd .github/actions/incremental-build
+ for test in *_test.sh; do
Review Comment:
💡 **Suggestion:** Guard against an empty glob match with `nullglob` — if the
directory ever has no `*_test.sh` files, bash will pass the literal string
`*_test.sh` to `bash`, causing a confusing error.
```suggestion
shopt -s nullglob
for test in *_test.sh; do
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
