jamesnetherton commented on PR #29469: URL: https://github.com/apache/camel/pull/29469#issuecomment-6740757087
@davsclaus thanks for the review, good catch on camel-spring-boot. Addressed in 8c551bf16802: - `localDiff` now fetches `origin/<base>` itself when the merge base is not in the checkout, with the same deepen loop (now `fetchBaseBranch` in `pr_diff.sh`). CSB works from its depth-1 checkout without a companion PR. The two fetch steps in `pr-build-main.yml` reuse the function instead of their own copy of the loop, and the step comment mentions the diff fallback. - `/component-test` is covered by the same change: with the fetch step skipped, `localDiff` fetches on its own, so I kept failing on an empty diff rather than continuing with the extra modules only. - `pr_diff_test.sh` has a component-removal case, and a depth-1 clone without `origin/main` (the CSB setup) that checks the fallback fetches and deepens to the right merge base. _Claude Code on behalf of @jamesnetherton_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
