jamesnetherton commented on code in PR #29469:
URL: https://github.com/apache/camel/pull/29469#discussion_r4512361505
##########
.github/workflows/pr-ci-scripts-validation.yml:
##########
@@ -65,3 +65,11 @@ jobs:
run: |
cd .github/actions/incremental-build
uv run --with defusedxml python3 -m unittest discover --verbose
+
+ - name: Test the incremental build shell scripts
+ shell: bash
+ run: |
+ cd .github/actions/incremental-build
+ for test in *_test.sh; do
Review Comment:
Thanks, but I'd rather keep it as is. Without `nullglob`, an empty match
runs `bash '*_test.sh'`, which fails, and the step fails with it (GHA's `bash`
shell runs with `-e`). With `nullglob` the loop would run no tests and the step
would pass green, the silent "nothing tested" result this PR removes from the
incremental build.
_Claude Code on behalf of @jamesnetherton_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
