[
https://issues.apache.org/jira/browse/CASSANDRA-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851093#action_12851093
]
Jonathan Ellis commented on CASSANDRA-827:
------------------------------------------
Looks pretty good to me!
- 02: Can we provide a .serializer().de/serialize interface to the Migrations,
instead of getBytes, for consistency w/ the other code? (Alternatively, we
could move that stuff into a Thrift class; rolling that stuff by hand is
something I'd like to move away from.)
- 04: the requesting of CF definitions looks like it should be done in a gossip
listener, not directly in Gossiper. we shouldn't have to modify Gossiper
internals at all; the CF defs should go in a new applicationstate, and someone
(KSMetaData?) should register an onChange listener that does the requesting of
updates.
"seed nodes should try to get schema updates from other seed nodes before going
into normal mode" seems like complexity that doesn't really buy us much.
I'm not sure what "don't bootstrap if there are no tables defined" gets us
either.
we should make a best effort to push the migration out to all live nodes, and
let dead or partitioned ones catch up via the gossip method. relying entirely
on gossip makes propagation pretty slow even when cluster is entirely healthy.
(the "push" could just be a hint for "everyone request defns from me.") doing
this in another ticket is fine imo.
- 08: if RowMutation is still using strings instead of cfids, doesn't that
leave us vulnerable to the bug discussed earlier where it gets applied to the
wrong CF after a rename?
> Add hooks that recognize when system KS is updated.
> ---------------------------------------------------
>
> Key: CASSANDRA-827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-827
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
> Fix For: 0.7
>
> Attachments: v1-0001-remove-unused-JoinMessage.txt,
> v1-0002-Refactor-so-meta-mutations-can-be-serialized-and-moved.txt,
> v1-0003-move-ConfigurationException-to-its-own-class-file.txt,
> v1-0004-Gossip-metadata-version-and-request-updates.txt,
> v1-0005-thrift-changes.txt,
> v1-0006-switch-to-reading-schema-configuration-from-storage.txt,
> v1-0007-thrift-impl.txt, v1-0008-use-cfid-for-all-mutations.txt
>
>
> Add hooks that recognize when system KS is updated.
> Figure out the best way to refresh the collections in DD, perform the adds,
> deletes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
