[
https://issues.apache.org/jira/browse/CASSANDRA-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325862#comment-14325862
]
Benedict commented on CASSANDRA-8692:
-------------------------------------
On the whole the latest patch is looking good to me. The main thing to decide
is which version this will make its way into. There are good arguments either
way, so I'll defer to strong opinions.
A few nits:
* System properties should propbably be lowercase to be consistent with prior
form
* I think it would be nice to make MACS and THMACS share code, esp. with the
DEBUG logic
* The assertions on every sample logging probably aren't necessary unless
DEBUG_MODE is enabled (if at all, now it's sorted)
I've pushed an update to my repository
[here|https://github.com/belliottsmith/cassandra/tree/C-8692] that also fixes
the ugly unchecked generics casting.
> Coalesce intra-cluster network messages
> ---------------------------------------
>
> Key: CASSANDRA-8692
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8692
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Ariel Weisberg
> Assignee: Ariel Weisberg
> Fix For: 2.1.4
>
> Attachments: batching-benchmark.png
>
>
> While researching CASSANDRA-8457 we found that it is effective and can be
> done without introducing additional latency at low concurrency/throughput.
> The patch from that was used and found to be useful in a real life scenario
> so I propose we implement this in 2.1 in addition to 3.0.
> The change set is a single file and is small enough to be reviewable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
