[
https://issues.apache.org/jira/browse/CASSANDRA-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328251#comment-14328251
]
Benedict commented on CASSANDRA-8692:
-------------------------------------
bq. To me the way it reads
Bear in mind you wrote it; so you don't get to say how it reads too :)
bq. not be filled with more than outSize elements
Then let's call it something like "coalesceLimit" or simply "maxItems"
Since it doesn't really make much sense to pass in non-empty, I would prefer a
comment that it should be empty, an assert that it is empty, and to then treat
it as such. Defending against potential future copy paste errors is too meta
for me; I'd rather code clarity right now. But we've already spent too long
talking about this...
> Coalesce intra-cluster network messages
> ---------------------------------------
>
> Key: CASSANDRA-8692
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8692
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Ariel Weisberg
> Assignee: Ariel Weisberg
> Fix For: 2.1.4
>
> Attachments: batching-benchmark.png
>
>
> While researching CASSANDRA-8457 we found that it is effective and can be
> done without introducing additional latency at low concurrency/throughput.
> The patch from that was used and found to be useful in a real life scenario
> so I propose we implement this in 2.1 in addition to 3.0.
> The change set is a single file and is small enough to be reviewable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
