[
https://issues.apache.org/jira/browse/CASSANDRA-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328186#comment-14328186
]
Ariel Weisberg commented on CASSANDRA-8692:
-------------------------------------------
bq.One more tiny nit: I'd prefer to use "- 1" instead of "- out.size()" since
we can only have added one item, so it seems more consistent with honouring the
caller's provision of capacity.
I went to make this change and found that in some instances it's not -1 since
the out can have more than one thing in it. That's why I did the first way
which is not sensitive to context and gives the caller what they asked for. To
me hard coding -1 instead of expressing the actual constraint we are supposed
to be maintaining is worse on the fragility and readability scale..
> Coalesce intra-cluster network messages
> ---------------------------------------
>
> Key: CASSANDRA-8692
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8692
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Ariel Weisberg
> Assignee: Ariel Weisberg
> Fix For: 2.1.4
>
> Attachments: batching-benchmark.png
>
>
> While researching CASSANDRA-8457 we found that it is effective and can be
> done without introducing additional latency at low concurrency/throughput.
> The patch from that was used and found to be useful in a real life scenario
> so I propose we implement this in 2.1 in addition to 3.0.
> The change set is a single file and is small enough to be reviewable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
