[
https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394779#comment-14394779
]
Joshua McKenzie commented on CASSANDRA-8584:
--------------------------------------------
Removed NoSpamLogger in deference to CASSANDRA-9029. A quick run against
2.1-HEAD w/this patch gives:
{noformat}
grep trySkipCache 8584_utest.txt | wc -l
432
{noformat}
I'll either wait until 9029's in or track down the source of the failing
trySkipCache calls and create another ticket for that. I'd prefer to have a
clean slate w/regards to our page-cache prompting before committing this.
> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
> Key: CASSANDRA-8584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Joshua McKenzie
> Assignee: Ariel Weisberg
> Priority: Trivial
> Fix For: 2.1.5
>
> Attachments: 8584_v1.txt, NoSpamLogger.java, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our
> other CLibrary calls, it's thread-safe and we could print out more helpful
> information if we failed to prompt the kernel to skip the page cache. That
> system call should always succeed unless we have an invalid fd as it's free
> to ignore us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
