[
https://issues.apache.org/jira/browse/CASSANDRA-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483943#comment-14483943
]
Tyler Hobbs commented on CASSANDRA-7557:
----------------------------------------
Overall the patch looks very good!
Some review comments:
* Can you add tests for drop permissions on functions? In particular, make
sure to cover non-existent functions with "IF EXISTS". I'm not sure what the
correct behavior there is if the function doesn't exist -- I suppose it should
require {{DROP}} permissions at the keyspace or root level?
* In ModificationStatement, there's a TODO about whether restrictions,
operations, and conditions can be null inside non-null collections. I believe
the answer is "no", and we should be able to update {{usesFunction()}} with the
same changes as well.
* There's a leftover TODO in {{FunctionResource}}
* In {{Term.NonTerminal}} you pointed out a bug in {{usesFunction}} in a
comment. Can you open a ticket for that if you haven't already? (We'll also
want to add tests for that.)
* Out of curiosity, why does FunctionResource need to be Comparable?
> User permissions for UDFs
> -------------------------
>
> Key: CASSANDRA-7557
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7557
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Tyler Hobbs
> Assignee: Sam Tunnicliffe
> Labels: client-impacting, cql, udf
> Fix For: 3.0
>
>
> We probably want some new permissions for user defined functions. Most
> RDBMSes split function permissions roughly into {{EXECUTE}} and
> {{CREATE}}/{{ALTER}}/{{DROP}} permissions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
