[
https://issues.apache.org/jira/browse/CASSANDRA-8773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485028#comment-14485028
]
Robert Stupp commented on CASSANDRA-8773:
-----------------------------------------
Hm - it doesn’t work. I just tried {{user
profile=$PROJECT_DIR$/tools/cqlstress-example.yaml ops(insert=1,validate=1)}}
and
{{org.apache.cassandra.stress.operations.userdefined.ValidatingSchemaQuery.JavaDriverRun#run}}
returns false (all three cases). Can you check that?
Some questions:
* Can you explain (and add it as an inline comment) what the _including
upper/lower bound_ booleans in
{{org.apache.cassandra.stress.operations.userdefined.ValidatingSchemaQuery#create}}
do?
Some nits/clarifications:
* Please rename
{{org.apache.cassandra.stress.operations.userdefined.ValidatingSchemaQuery.Runner#iter}}
to {{partitionIter}}
* Some superfluous usages of {{static}} keyword (e.g. {{static enum}})
* Please switch from line comments to block comments and use javadoc links. For
example
{{org.apache.cassandra.stress.generate.PartitionIterator.MultiRowIterator#advance()}}
notes _delegates to advance(int)_ but there is no such method with that
signature. Using {{\{@link #advance(int)\}}} would make this obvious (and
produce a build error in the best case). I won’t fight for it now but would be
glad to have that in future changes.
> cassandra-stress should validate its results in "user" mode
> -----------------------------------------------------------
>
> Key: CASSANDRA-8773
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8773
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Benedict
> Assignee: Benedict
> Labels: stress
> Fix For: 2.1.5
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
