[ 
https://issues.apache.org/jira/browse/CASSANDRA-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597874#comment-14597874
 ] 

Benedict commented on CASSANDRA-9499:
-------------------------------------

bq. That doesn't make the tempBuffer in DataOutputPlus any safer. If a 
DataOutputPlus ends up wrapping another DataOutputPlus it could go poorly.

Well, that's kind of out-of-scope for this ticket since it's already there as a 
risk, and this has already scope-creeped. But yes, I agree - making that a 
Queue/List of temporary buffers *could* be sensible (or just nulling each time 
we extract, and failing if we double-use).

bq. Also are we doing this as two or one commits?

I've no opinion on that...

> Introduce writeVInt method to DataOutputStreamPlus
> --------------------------------------------------
>
>                 Key: CASSANDRA-9499
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9499
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Ariel Weisberg
>            Priority: Minor
>             Fix For: 3.0 beta 1
>
>
> CASSANDRA-8099 really could do with a writeVInt method, for both fixing 
> CASSANDRA-9498 but also efficiently encoding timestamp/deletion deltas. It 
> should be possible to make an especially efficient implementation against 
> BufferedDataOutputStreamPlus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to