[ 
https://issues.apache.org/jira/browse/CASSANDRA-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597432#comment-14597432
 ] 

Benedict commented on CASSANDRA-9499:
-------------------------------------

[~aweisberg]: i've pushed a small further tweak 
[here|https://github.com/belliottsmith/cassandra/tree/C-9499-madness] to 
simplify the readMinimum logic, and reduce the number of operations (and size 
of code) on the normal path.

I'm also ambivalent about not using the VInt methods in the switch for 
SerializingCache, but it's not super-important (since obviously the inner 
serialization will not until 8099, but 8099 is unlikely to touch this 
particular place)

Otherwise, LGTM. If you can squash and otherwise prepare for commit, we can get 
it into mainline.

> Introduce writeVInt method to DataOutputStreamPlus
> --------------------------------------------------
>
>                 Key: CASSANDRA-9499
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9499
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Ariel Weisberg
>            Priority: Minor
>             Fix For: 3.0 beta 1
>
>
> CASSANDRA-8099 really could do with a writeVInt method, for both fixing 
> CASSANDRA-9498 but also efficiently encoding timestamp/deletion deltas. It 
> should be possible to make an especially efficient implementation against 
> BufferedDataOutputStreamPlus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to