[ 
https://issues.apache.org/jira/browse/CASSANDRA-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597838#comment-14597838
 ] 

Benedict commented on CASSANDRA-9499:
-------------------------------------

bq. You can get github (and git can probably do this as well)...

When I'm committing on behalf of somebody else (and I thought we were nits 
away), I expect a fully-formed commit with CHANGES.txt wired up, commit message 
provided, etc.

bq. Once for varint and once when wrapping a bytebuffer

VIntCoding wouldn't really be able to access the buffer internal to DOSP, so my 
expectation was (since we know how big this buffer needs to be, which is not 
very big at all) that we would introduce a {{tempBuffer}} in VIntCoding, and 
introduce an {{\@Inline}} annotated static method that takes the size and 
encodes into the {{tempBuffer}}, returning the byte array which callers must 
discard immediately after using. This is guaranteed not to be used more than 
once simultaneously, and can be invoked from both locations.

> Introduce writeVInt method to DataOutputStreamPlus
> --------------------------------------------------
>
>                 Key: CASSANDRA-9499
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9499
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Ariel Weisberg
>            Priority: Minor
>             Fix For: 3.0 beta 1
>
>
> CASSANDRA-8099 really could do with a writeVInt method, for both fixing 
> CASSANDRA-9498 but also efficiently encoding timestamp/deletion deltas. It 
> should be possible to make an especially efficient implementation against 
> BufferedDataOutputStreamPlus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to