[
https://issues.apache.org/jira/browse/CASSANDRA-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980252#comment-14980252
]
Sylvain Lebresne commented on CASSANDRA-10365:
----------------------------------------------
A few early remarks on the 2 first patch (the 2nd patch really, the 1st one is
fine):
* The naming of {{Schema.only()}} doesn't make it extra clear that it expects
keyspace names. Maybe {{getKeyspaces()}} (that would also be more consistent
with the rest of the class namings)?
* I tend to agree that the reloading in {{Keyspace.initCf}} shouldn't be
necessary so I would maybe prefer removing it rather that leaving a TODO that
will surely stay there a long time.
* In {{SchemaKeyspace.fetchKeyspacesOnly}}, the initial query looks unecessary.
If it's there as a way to exclude any unexisting keyspace, a comment explaining
so would be welcome. But it's only used after having applied mutation that we
knew applied to the keyspace passed to this method, so really, I'm not
convinced it's useful.
* There is minor inconsistencies in {{SchemaKeyspace}} method naming: you still
have {{createColumnFromColumnRow}} for instance, but renamed
{{createAggregateFromAggregateRow}} to {{createAggregateFromRow}}. I'd just
rename them all to {{createXFromRow}} really as that's easier. On the
functions/aggregates, you use {{fetchFunctions}} to mean both UDF and UDA, then
{{fetchUDFs}} for UDF but then {{createFunctionFromRow}} for UDF (should rename
the last one). Also, {{createAggregateFromRow}} would be more consistent as
{{createUDAFromRow}}.
* Any reason for removing the {{testConversionsInverses}} in {{CFMetadataTest}}
rather than converting it to the new code? I do feel this was a good test to
have. At the very least, the test was testing the inversion of hrift
conversions which isn't impacted by the patch and should be preserved.
I haven't looked at the 3rd patch yet at all so apologies if any of this is
fixed by that 3rd patch.
> Consider storing types by their CQL names in schema tables instead of
> fully-qualified internal class names
> ----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-10365
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10365
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Labels: client-impacting
> Fix For: 3.0.0
>
>
> Consider saving CQL types names for column, UDF/UDA arguments and return
> types, and UDT components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
