[
https://issues.apache.org/jira/browse/CASSANDRA-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980775#comment-14980775
]
Sylvain Lebresne commented on CASSANDRA-10365:
----------------------------------------------
Remarks on the 3rd patch (understanding that it's not 100% complete):
* Bit of a nitpick, but I don't love the addition of the keyspace to {{Types}}
because it's not consistent with it's siblings ({{Tables}} and {{Functions}}).
It seems to be there just because we need it, along with the types, in some of
{{CQL3Type.Raw.prepare(Types)}} implementations. Can't we just pass the
keyspace name as a first argument to that method instead? If you care about
leaving it in {{Types}} however, lets at least take it into account in
{{equals}} and {{hashCode}}.
* {{CQL3Type.UserDefined.toString()}} doesn't quote stuffs properly (if the udt
name is a quoted name). {{SchemaKeyspace.bbToString()}} has the same problem.
There is a {{ColumnIdentifier.maybeQuote()}} method that could be reused for
info.
* Can you add a comment to fetchDroppedColumns to remind the reader why using
Types.none() is ok (just a pointer to expandUserTypes is fine).
* The use of {{Types.none()}} in {{CQLSSTableWriter}} striked me as weird. That
made realize however that I wasn't sure if UDT were actually usable with
{{CQLSSTableWriter}} at all, and how if they are. Do you know more?
(side-note: making the remaining change in a new commit would be appreciated :))
> Consider storing types by their CQL names in schema tables instead of
> fully-qualified internal class names
> ----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-10365
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10365
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Labels: client-impacting
> Fix For: 3.0.0
>
>
> Consider saving CQL types names for column, UDF/UDA arguments and return
> types, and UDT components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
