[ 
https://issues.apache.org/jira/browse/CASSANDRA-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980470#comment-14980470
 ] 

Aleksey Yeschenko commented on CASSANDRA-10365:
-----------------------------------------------

bq. In SchemaKeyspace.fetchKeyspacesOnly, the initial query looks unecessary. 
If it's there as a way to exclude any unexisting keyspace, a comment explaining 
so would be welcome. But it's only used after having applied mutation that we 
knew applied to the keyspace passed to this method, so really, I'm not 
convinced it's useful.

It does look a bit silly, doesn't it. Retroactively, it kind of makes sense - 
it's possible that one of the mutation involved in merging drops a keyspace, so 
we need to exclude them. But I don't think I put it there for any particular 
reason. Its presence doesn't bother me much - it's still huge savings all over 
- now that we don't need to read the previous state at all, and with reload 
changes, but I'll have a look.

> Consider storing types by their CQL names in schema tables instead of 
> fully-qualified internal class names
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10365
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10365
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>              Labels: client-impacting
>             Fix For: 3.0.0
>
>
> Consider saving CQL types names for column, UDF/UDA arguments and return 
> types, and UDT components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to