[
https://issues.apache.org/jira/browse/CASSANDRA-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066163#comment-15066163
]
Stefania commented on CASSANDRA-9303:
-------------------------------------
bq. I tested the new config options and the ingest rate is now working like a
charm.
Thanks, I made a slight modification to the ingest rate algorithm to give a
better chance to the receive meter to show the statistics. The ingest rate
should still be pretty accurate.
bq. I was initially thinking that while \[copy\] is a global section,
\[copy-from*\] and \[copy-to*\] are exclusive sections for these commands, so
for example if you define INGESTRATE by mistake in the \[copy-to\] section it's
not picked up by a copy-from execution.
That's correct, {{copy-to*}} sections are not read in from executions and
vice-versa. I've added a check to explicitly skip invalid or wrong direction
options from config files along with more log messages so that it should be
easier to see that an option is not read or ignored.
bq. Can you also add some examples to conf/cqlshrc.sample ? And maybe also
update the cql protocol version there which is quite old.
Done.
bq.Also in the Reading options from /home/paulo/.cqlsh/cqlshrc message, maybe
print which options are being read to improve clarity (don't worry if not
straightforward)
Done.
bq. Cool! Since it's an edge-case I guess we can omit in the help and print a
message instead in case it happens.
Done.
bq. Sounds good, it just seems the skipped columns is still being printed on
the message Starting copy of keyspace1.standard1 with columns \['key', 'C0',
'C1', 'C2', 'C3', 'C4'\]. (you fixed before, but it came back somehow).
It came back because of the changes to SKIPCOLS, it should be OK now.
bq. Move csv_dialect_defaults from cqlsh.py to copyutil.py
Done, I got rid of it.
bq. Move exclusive skip_columns field from CopyTask to ImportTask
Done, I've also moved it from ChildProcess to ImportProcess.
bq. csv_options are a bit misleading since they are not exclusive csv-related
options, can we maybe rename the tuple CopyOptions(csv, dialect, unrecognized)
to Options(copy, dialect, unrecognized)?
Done
--
I need to clarify with [~iamaleksey] for which branch we need to commit this
since CASSANDRA-9494 was only committed to trunk. I will up-merge later on
today once I know for sure.
> Match cassandra-loader options in COPY FROM
> -------------------------------------------
>
> Key: CASSANDRA-9303
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9303
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Stefania
> Priority: Critical
> Fix For: 2.1.x
>
>
> https://github.com/brianmhess/cassandra-loader added a bunch of options to
> handle real world requirements, we should match those.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
