[
https://issues.apache.org/jira/browse/CASSANDRA-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070852#comment-15070852
]
Stefania commented on CASSANDRA-9303:
-------------------------------------
Thank you for your input, we will commit to 2.1+ then.
--
bq. Only minor nit is to use {{os.linesep instead}} of {{'\n'}} on
{{_printmsg(msg, eol='\n')}}.
Nope, it's intentional and in fact I changed the {{os.linesep}} occurrences
that I found in other parts of the file
as well. See the doc here:
https://docs.python.org/2/library/os.html?highlight=linesep#os.linesep - on
Windows
{{os.linesep}} is '\r\n' which then becomes '\r\r\n' because '\n' is
automatically converted to '\r\n'
when writing to text files. I assume this includes stdout.
bq. can you just check the failing dtest
{{cqlsh_copy_tests.py:CqlshCopyTest.test_read_missing_partition_key}} from
CASSANDRA-10854
They pass only on the [dtest 9303
branch|https://github.com/stef1927/cassandra-dtest/commits/9303] since the
exception name has changed - I had to fix one more small thing in the code as
well.
I've also fixed a bug with COPY TO that I discovered when testing with VNODES
disabled.
bq. Feel free to squash and up-merge.
Squashed (except for the latest changes) and merged:
||2.1||2.2||3.0||trunk||
|[patch|https://github.com/stef1927/cassandra/commits/9303-2.1]|[patch|https://github.com/stef1927/cassandra/commits/9303-2.2]|[patch|https://github.com/stef1927/cassandra/commits/9303-3.0]|[patch|https://github.com/stef1927/cassandra/commits/9303]|
|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-2.1-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-2.2-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-dtest/]|
We have a problem running the Windows tests, aside from the long time it takes,
because we cannot parametrize the CASSCI job then we cannot use the 9303 dtest
branch and therefore most of the tests will fail because {{format_value()}} in
_formatting.py_ expects more parameters. The master branch tests won't exercise
most of the options either. I do not have a working Windows environment
available right now, would you be able to run _cqlsh_copy_tests.py_ on your
environment and then send me any errors? Alternatively I can create the dtest
pull request and run the tests on CASSCI once both PR and this ticket have been
committed, but we keep this ticket open until we've verified the Windows tests
are also OK.
> Match cassandra-loader options in COPY FROM
> -------------------------------------------
>
> Key: CASSANDRA-9303
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9303
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Stefania
> Priority: Critical
> Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
>
>
> https://github.com/brianmhess/cassandra-loader added a bunch of options to
> handle real world requirements, we should match those.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
