[
https://issues.apache.org/jira/browse/CASSANDRA-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082211#comment-15082211
]
Paulo Motta commented on CASSANDRA-9303:
----------------------------------------
Nice job, we`re nearly there! :) Now tests are passing locally on Windows and
code looks good. Some minor nits:
* Could you improve the local mutation check on {{BatchStatement}}, by using
{{StorageService.getLocalRanges}}, {{Range.isInRanges}} and also skip the
{{isMutationLocal()}} evaluation if the {{localMutationsOnly}} variable is
{{false}}. Also you can remove the cqlsh reference on the comment, since even
in a non-cqlsh context the warning is not necessary if there are only local
mutations in an unlogged batch.
* Although the fix for CASSANDRA-10938 looks harmless, I'm not sure if it could
have some unintended consequences, so I'd prefer to commit it separately after
discussion on CASSANDRA-10938.
Did you validate the performance of the new batch-by-replica approach? In the
end it seems CASSANDRA-10938 was not caused by batching by partition key and
there was a lot of back-and-forth between batch-by-replica vs
batch-by-partition, so it's not very clear which approach is the best. We could
probably do a more thorough evaluation/validation later, but it would be nice
to make sure our batching strategy performs well.
Since there are also java code changes, can you also submit unit tests in
addition to dtests on cassci? Thanks!
> Match cassandra-loader options in COPY FROM
> -------------------------------------------
>
> Key: CASSANDRA-9303
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9303
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Stefania
> Priority: Critical
> Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
>
> Attachments: dtest.out
>
>
> https://github.com/brianmhess/cassandra-loader added a bunch of options to
> handle real world requirements, we should match those.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
