[
https://issues.apache.org/jira/browse/CASSANDRA-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082700#comment-15082700
]
Stefania commented on CASSANDRA-9303:
-------------------------------------
bq. Could you improve the local mutation check on {{BatchStatement}}....
Done, sorry I totally missed the existence of those helper methods.
bq. Although the fix for CASSANDRA-10938 looks harmless...
I reverted it. I agree with your concerns but I am also equally worried about
people importing data with CASSANDRA-10938 still not fixed.
bq. Did you validate the performance of the new batch-by-replica approach?
Yes. Although the hybrid approach may cost us 2-3 seconds with a 1M
cassandra-stress benchmark with 3 nodes (~25 vs ~22 seconds), we do not impact
batching by partition key because that has priority. So, unlike the discussion
on CASSANDRA-9302, batching by partition key is still there and batching by
replica is just a backup approach.
It seems conceptually wrong to me to send UNLOGGED batches with non-local
partitions:
* we'll trigger the WARN that we worked towards removing for local partitions
* we also increase the risk of timeouts if one node gets overloaded
CI pending including unit tests, here are all the links:
||2.1||2.2||3.0||trunk||
|[patch|https://github.com/stef1927/cassandra/commits/9303-2.1]|[patch|https://github.com/stef1927/cassandra/commits/9303-2.2]|[patch|https://github.com/stef1927/cassandra/commits/9303-3.0]|[patch|https://github.com/stef1927/cassandra/commits/9303]|
|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-2.1-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-2.2-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-testall/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-2.1-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-2.2-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9303-dtest/]|
> Match cassandra-loader options in COPY FROM
> -------------------------------------------
>
> Key: CASSANDRA-9303
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9303
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Stefania
> Priority: Critical
> Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
>
> Attachments: dtest.out
>
>
> https://github.com/brianmhess/cassandra-loader added a bunch of options to
> handle real world requirements, we should match those.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
