Nachiket Patil commented on CASSANDRA-12681:

Agree. I think it is time to revisit some restrictions around keyspace 
creation. For backward compatibility's sake, I haven't removed the code in 
`AbstractReplicationStrategy` where `ConfigurationException` is ignored in 
method `createReplicationStrategy()`. And `ConfigurationException` is thrown in 
`validateReplicationStrategy()`. This way, Cassandra will start even if there 
are any keyspaces already present with incorrect replication setting but will 
not allow creation of new ones or altering existing ones to wrong setting.

> Reject empty options and invalid DC names in replication configuration while 
> creating or altering a keyspace.
> -------------------------------------------------------------------------------------------------------------
>                 Key: CASSANDRA-12681
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12681
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Distributed Metadata
>            Reporter: Nachiket Patil
>            Assignee: Nachiket Patil
>            Priority: Minor
>         Attachments: trunkpatch.diff, v3.0patch.diff
> Add some restrictions around create / alter keyspace with 
> NetworkTopologyStrategy:
> 1. Do not accept empty replication configuration (no DC options after class). 
> Cassandra checks that SimpleStrategy must have replication_factor option but 
> does not check that at least one DC should be present in the options for 
> NetworkTopologyStrategy.
> 2. Cassandra accepts any random string as DC name replication option for 
> NetworkTopologyStrategy while creating or altering keyspaces. Add a 
> restriction that the options specified is valid datacenter name. Using 
> incorrect value or simple mistake in typing the DC name can cause outage in 
> production environment.

This message was sent by Atlassian JIRA

Reply via email to