[
https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15518218#comment-15518218
]
Jeff Jirsa commented on CASSANDRA-12681:
----------------------------------------
Overall looks good.
Pushed to my github so I could kickoff tests. Also have 1 important and 3 minor
suggestions (which I've pushed here for your convenience:
[3.0|https://github.com/apache/cassandra/commit/49138d380048d2b891e2cf07dd788f01355c2ebe]
and
[trunk|https://github.com/apache/cassandra/commit/e43894aa0ec5f9a91aa8b8ceb6ea98509ff2d14a]):
- Recreate test for CASSANDRA-4278 in CreateTest where it should have been in
the first place (it was a early CQL bug, but we shouldn't reduce test coverage)
- Spelling correction on
testAlterKeyspaceWithNoOptionThrowsConfigurationExcepotion
- Add mixed valid/invalid DC statement to create and alter tests
- Remove double semi-colon
|[3.0
branch|https://github.com/apache/cassandra/compare/cassandra-3.0...jeffjirsa:cassandra-12681-3.0]|[testall|http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-3.0-testall/]|[dtests|http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-3.0-dtest/]|
|[trunk|https://github.com/apache/cassandra/compare/trunk...jeffjirsa:cassandra-12681]|[testall|http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-testall/]|[dtests|http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-dtest/]|
This still un-does CASSANDRA-4795, and [~xedin] noted:
{quote}
Ok, so changing this in 1.2.1 probably was a bit unfair to people, because e.g.
Titan relies on providing custom strategy option 'titan-version' and it can't
do custom strategy because there is no control of what version people install,
can we please start warning people about unrecognized options in the strategy
again instead of restricting them, because those options are sometimes very
convenient to safe meta-information.
{quote}
I'll look to see if modern versions of titan still do this - if so, we may need
to think about whether or not it's worth breaking other applications.
> Reject empty options and invalid DC names in replication configuration while
> creating or altering a keyspace.
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-12681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12681
> Project: Cassandra
> Issue Type: Improvement
> Components: Distributed Metadata
> Reporter: Nachiket Patil
> Assignee: Nachiket Patil
> Priority: Minor
> Attachments: trunkpatch.diff, v3.0patch.diff
>
>
> Add some restrictions around create / alter keyspace with
> NetworkTopologyStrategy:
> 1. Do not accept empty replication configuration (no DC options after class).
> Cassandra checks that SimpleStrategy must have replication_factor option but
> does not check that at least one DC should be present in the options for
> NetworkTopologyStrategy.
> 2. Cassandra accepts any random string as DC name replication option for
> NetworkTopologyStrategy while creating or altering keyspaces. Add a
> restriction that the options specified is valid datacenter name. Using
> incorrect value or simple mistake in typing the DC name can cause outage in
> production environment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
