[
https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524924#comment-15524924
]
Jeff Jirsa commented on CASSANDRA-12681:
----------------------------------------
[~nachiket_patil] - it looks like your patch breaks dtest for both 3.0 and
trunk:
http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-3.0-dtest/3/testReport/junit/junit/cql_tests/StorageProxyCQLTester/keyspace_test/
http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-dtest/lastUnstableBuild/testReport/junit/cql_tests/StorageProxyCQLTester/keyspace_test/
The test is here:
https://github.com/riptano/cassandra-dtest/blob/master/cql_tests.py#L73-L104
The dtest uses a datacenter named 'dc1', though ccm uses 'datacenter1'.
I've opened a pull request to the dtests repo:
https://github.com/riptano/cassandra-dtest/pull/1348 . I don't have write
access to that repo, so we'll have to wait for someone who does to commit that,
and then we'll kick off another dtest.
> Reject empty options and invalid DC names in replication configuration while
> creating or altering a keyspace.
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-12681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12681
> Project: Cassandra
> Issue Type: Improvement
> Components: Distributed Metadata
> Reporter: Nachiket Patil
> Assignee: Nachiket Patil
> Priority: Minor
> Fix For: 3.0.x, 3.x
>
> Attachments: trunkpatch.diff, v3.0patch.diff
>
>
> Add some restrictions around create / alter keyspace with
> NetworkTopologyStrategy:
> 1. Do not accept empty replication configuration (no DC options after class).
> Cassandra checks that SimpleStrategy must have replication_factor option but
> does not check that at least one DC should be present in the options for
> NetworkTopologyStrategy.
> 2. Cassandra accepts any random string as DC name replication option for
> NetworkTopologyStrategy while creating or altering keyspaces. Add a
> restriction that the options specified is valid datacenter name. Using
> incorrect value or simple mistake in typing the DC name can cause outage in
> production environment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
