[
https://issues.apache.org/jira/browse/CASSANDRA-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392161#comment-16392161
]
Jaydeepkumar Chovatia commented on CASSANDRA-13529:
---------------------------------------------------
Hi [~djoshi3]
Thank You! for reviewing this code.
I've incorporated most of the comments.
For the following comment:
{quote}
There is a lot that was added to SchemaQuery. It would be beneficial if you add
two classes CASQueryStatic and CASQueryDynamic inheriting from a new class
called CASQuery.
{quote}
I didn't create base-class {{CasQuery}} derive-class {{CASQueryStatic,
CASQueryDynamic}} because {{CASQueryStatic}} is same as any other query as it
doesn't require special treatment. Only for {{CASQueryDynamic}} we need to
fetch current db values and then replace before doing actual operation. But I
got your concern hence I have created a new class for {{CASQueryDynamic}} and
moved majority of code from {{SchemaQuery}} --> {{CASQueryDynamic}} to keep
mainline simple. Please review this update patch and let me know your feedback.
|| trunk ||
| [patch|
https://github.com/apache/cassandra/compare/trunk...jaydeepkumar1984:CASSANDRA-13529?expand=1]
|
| [uTest| https://circleci.com/gh/jaydeepkumar1984/cassandra/37] |
Jaydeep
> cassandra-stress light-weight transaction support
> -------------------------------------------------
>
> Key: CASSANDRA-13529
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13529
> Project: Cassandra
> Issue Type: New Feature
> Components: Stress
> Reporter: Jaydeepkumar Chovatia
> Assignee: Jaydeepkumar Chovatia
> Priority: Minor
> Fix For: 4.x
>
> Attachments: 13529.txt, lwttest.yaml
>
>
> It would be nice to have a light-weight transaction support in
> cassandra-stress.
> Although currently in cassandra-stress we can achieve light-weight
> transaction partially by using static conditions like "IF col1 != null" or
> "IF not EXIST".
> If would be ideal to have full fledged light-weight transaction support like
> "IF col1 = ? and col2 = ?". One way to implement is to read values from
> Cassandra and use that in the condition so it will execute all the paxos
> phases in Cassandra.
> Please find git link for the patch:
> https://github.com/apache/cassandra/compare/trunk...jaydeepkumar1984:13529-trunk?expand=1
> ||trunk|
> |[branch|https://github.com/jaydeepkumar1984/cassandra/tree/13529-trunk]|
> |[utests|https://circleci.com/gh/jaydeepkumar1984/cassandra/8]|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
