[
https://issues.apache.org/jira/browse/CASSANDRA-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409128#comment-16409128
]
Dinesh Joshi commented on CASSANDRA-13529:
------------------------------------------
Hi [[email protected]], the patch looks like it's in the right
direction. There are a few things we can do to make it better -
# In {{SchemaQuery}}'s constructor, you're passing it's partially constructed
reference to {{CASQueryDynamicConditions}}. Don't do this (See:
https://www.ibm.com/developerworks/library/j-jtp0618/).
# {{CASQueryDynamicConditions}} should ideally inherit from
{{SchemaStatement}} class and perhaps call it {{CASQuery}} (Making it a sibling
of {{SchemaQuery}} class).
# You can modify {{SettingsCommandUser::getFactory}} so {{CASQuery}} type
would be a new query type to choose.
> cassandra-stress light-weight transaction support
> -------------------------------------------------
>
> Key: CASSANDRA-13529
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13529
> Project: Cassandra
> Issue Type: New Feature
> Components: Stress
> Reporter: Jaydeepkumar Chovatia
> Assignee: Jaydeepkumar Chovatia
> Priority: Minor
> Fix For: 4.x
>
> Attachments: 13529.txt, lwttest.yaml
>
>
> It would be nice to have a light-weight transaction support in
> cassandra-stress.
> Although currently in cassandra-stress we can achieve light-weight
> transaction partially by using static conditions like "IF col1 != null" or
> "IF not EXIST".
> If would be ideal to have full fledged light-weight transaction support like
> "IF col1 = ? and col2 = ?". One way to implement is to read values from
> Cassandra and use that in the condition so it will execute all the paxos
> phases in Cassandra.
> Please find git link for the patch:
> https://github.com/apache/cassandra/compare/trunk...jaydeepkumar1984:13529-trunk?expand=1
> ||trunk|
> |[branch|https://github.com/jaydeepkumar1984/cassandra/tree/13529-trunk]|
> |[utests|https://circleci.com/gh/jaydeepkumar1984/cassandra/8]|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
