[
https://issues.apache.org/jira/browse/CASSANDRA-13698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430040#comment-16430040
]
Lerh Chuan Low commented on CASSANDRA-13698:
--------------------------------------------
Hi Paulo Motta,
My bad. I just submitted it as patch available. If git branches float your boat
more, here they are:
https://github.com/apache/cassandra/compare/trunk...juiceblender:cassandra-13698
https://github.com/apache/cassandra/compare/cassandra-3.11...juiceblender:cassandra-13698-3.11
https://github.com/apache/cassandra/compare/cassandra-3.0...juiceblender:cassandra-13698-3.0
Just a heads up; my CircleCI unit tests do work on trunk, but I can't for the
life of me figure out why it doesn't work on 3.0 or 3.X. On 3.X it eventually
times out, on 3.0 the errors doesn't seem related to my changes, e.g
https://circleci.com/gh/instaclustr/cassandra/9#tests/containers/2 and that
test runs perfectly fine on my local. I'm thinking of actually running tests on
3.11.2 and 3.0.16 to see if there are actually any errors on those tags, that
may take a while still.
> Reinstate or get rid of unit tests with multiple compaction strategies
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-13698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13698
> Project: Cassandra
> Issue Type: Test
> Components: Testing
> Reporter: Paulo Motta
> Assignee: Lerh Chuan Low
> Priority: Minor
> Labels: lhf
> Attachments: 13698-3.0.txt, 13698-3.11.txt, 13698-trunk.txt
>
>
> At some point there were (anti-)compaction tests with multiple compaction
> strategy classes, but now it's only tested with {{STCS}}:
> *
> [AnticompactionTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/AntiCompactionTest.java#L247]
> *
> [CompactionsTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/CompactionsTest.java#L85]
> We should either reinstate these tests or decide they are not important and
> remove the unused parameter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
