[
https://issues.apache.org/jira/browse/CASSANDRA-13698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504262#comment-16504262
]
Lerh Chuan Low commented on CASSANDRA-13698:
--------------------------------------------
Hi Paulo,
It looks like there may have been a bad merge - the patch for 3.0 may have
gotten applied to 3.11 instead. The project currently doesn't compile - the
offending lines are here:
{code:java}
Clustering startClustering = Clustering.make(ByteBufferUtil.bytes("0"));
Clustering endClustering = Clustering.make(ByteBufferUtil.bytes("b"));
{code}
And
{code:java}
try (ReadExecutionController executionController =
command.executionController();
PartitionIterator iterator = command.executeInternal(executionController))
{code}
[^13698-hotfix.txt] is a patch, and here's the branch if it floats your boat
more:
[https://github.com/apache/cassandra/compare/cassandra-3.11...juiceblender:cassandra-13698-hotfix?expand=1]
The test runs locally and Cassandra also starts. Here's the CCI:
[https://circleci.com/gh/juiceblender/cassandra/97]
PS: Thanks for the explanation, the ninja test works for me :)
> Reinstate or get rid of unit tests with multiple compaction strategies
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-13698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13698
> Project: Cassandra
> Issue Type: Test
> Components: Testing
> Reporter: Paulo Motta
> Assignee: Lerh Chuan Low
> Priority: Minor
> Labels: lhf
> Fix For: 4.0, 3.0.17, 3.11.3
>
> Attachments: 13698-3.0.txt, 13698-3.11.txt, 13698-hotfix.txt,
> 13698-trunk.txt
>
>
> At some point there were (anti-)compaction tests with multiple compaction
> strategy classes, but now it's only tested with {{STCS}}:
> *
> [AnticompactionTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/AntiCompactionTest.java#L247]
> *
> [CompactionsTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/CompactionsTest.java#L85]
> We should either reinstate these tests or decide they are not important and
> remove the unused parameter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
