[
https://issues.apache.org/jira/browse/CASSANDRA-14618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595982#comment-16595982
]
Jason Brown commented on CASSANDRA-14618:
-----------------------------------------
I'm halfway through reviewing, but here's the interim comments (outside of what
is on the PR).
- This patch depends directly on the DataStax driver. We are trying to
eliminate all explicit dependencies on the driver from the core database code,
so I think we need to do something here. Either more this fqltool code under
the {{/tools}} directory, or ... ? Not sure what else to recommend.
- instead of burdening the operator with knowing if the FQL files contain a
keyspace, is it possible to introduce an "FQL file version"? Something like
version "0" was the first version (pre-4.0), and version "1" now includes
keyspace information (official 4.0 version). I took a quick look at {{BinLog}},
and there's no obvious place to set arbitrary header information for the
{{ChronicleQueue}}. This change would affect CASSANDRA-14656's solution.
- You might consider moving the serialization (write) code in
{{FullQueryLogger.WeighableMarshallableBatch / WeighableMarshallableQuery}} and
deserialization (read) code in {{FQLQueryReader}} into a common location. But
that could be a followup ticket.
> Create fqltool replay command
> -----------------------------
>
> Key: CASSANDRA-14618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14618
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Major
> Labels: fqltool
> Fix For: 4.x
>
>
> Make it possible to replay the full query logs from CASSANDRA-13983 against
> one or several clusters. The goal is to be able to compare different runs of
> production traffic against different versions/configurations of Cassandra.
> * It should be possible to take logs from several machines and replay them in
> "order" by the timestamps recorded
> * Record the results from each run to be able to compare different runs
> (against different clusters/versions/etc)
> * If {{fqltool replay}} is run against 2 or more clusters, the results should
> be compared as we go
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
