[
https://issues.apache.org/jira/browse/CASSANDRA-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762977#comment-16762977
]
Jon Meredith commented on CASSANDRA-15009:
------------------------------------------
Nice patch and tests, I had a couple of minor comments across versions (and I'm
assuming the CircleCI changes were just for testing).
- RowUtil - why does the new
toObjects(List<ColumnSpecification>,Iterator<UntypedResultSet.Row) use compose,
rather than deserialize (or vice-versa, I'd be happy with either, but compose
seems the higher abstraction)?
- DistributedTestBase - I'm assuming toObjectArray is useful in other tests, I
don't see it referenced anywhere. It looks useful, I was just wondering why
you were adding it.
On trunk, it looks like there are some commits from
[CASSANDRA-14922|https://github.com/apache/cassandra/compare/trunk...ifesdjeen:CASSANDRA-14922-followup-3.0]
mixed in there with that branch. The trunk run failed with an OOM out of
metaspace after readWithSchemaDisagreement ran, were the extra commits an
attempt to get that passing?
> In-JVM Testing tooling for paging
> ---------------------------------
>
> Key: CASSANDRA-15009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15009
> Project: Cassandra
> Issue Type: Test
> Reporter: Alex Petrov
> Assignee: Jon Meredith
> Priority: Major
>
> Add distributed pager to in-jvm distributed tests to allow realistic pager
> tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
