Jon Meredith commented on CASSANDRA-15009:

I had a look at the latest state of branches, and the fix to prevent the 
executeInternal call looks good. The only minor question I had was whether 
currentPage should be explicitly initialized to null in the anonymous 
{{AbstractIterator}} returned by {{FromDistributedQuery.iterator}}? The 
implicit default of null is obviously fine, but I'm not sure what the 
conventions are for the project or if static analysis tools get upset by that 
kind of thing.

Will be interesting how the remaining dtests complete.

> In-JVM Testing tooling for paging
> ---------------------------------
>                 Key: CASSANDRA-15009
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15009
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Alex Petrov
>            Assignee: Jon Meredith
>            Priority: Major
> Add distributed pager to in-jvm distributed tests to allow realistic pager 
> tests.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to