[
https://issues.apache.org/jira/browse/CASSANDRA-15977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215435#comment-17215435
]
Andres de la Peña commented on CASSANDRA-15977:
-----------------------------------------------
It seems that the timeouts above are JUnit timeouts triggered when the
execution time of {{ReadRepairQueryTypesTest}} exceeds the six minutes
threshold defined
[{{test.distributed.timeout}}|https://github.com/apache/cassandra/blob/trunk/build.xml#L104].
I think that the timeout is for all the 544 tests in that class, which often
take longer than that.
Changing the value of
[{{test.distributed.timeout}}|https://github.com/apache/cassandra/pull/708/commits/96e3517304a0d7076ad754d0fcf188622a5e6263]
from 6 to 30 minutes seems to allow the tests to pass:
https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-jvm-dtest/293/
https://app.circleci.com/pipelines/github/adelapena/cassandra/125/workflows/caaba287-769e-4d8c-938f-1e08817bd943
https://app.circleci.com/pipelines/github/adelapena/cassandra/125/workflows/22b77c88-e274-4465-a9a8-b0595625c83c
https://app.circleci.com/pipelines/github/adelapena/cassandra/125/workflows/0f1550f5-d9de-4d81-93e6-34488e00c449
https://app.circleci.com/pipelines/github/adelapena/cassandra/125/workflows/7b6a7384-92d8-4230-a9ba-d6f4f2fe5798
Not sure whether we should just have a higher JUnit timeout for in-JMV dtests.
Having parameterized test classes that take some minutes to run seem legitimate
to me, and we are probably going to have more of them as part of the quality
epic. Perhaps we could consider setting the timeout as method-based, instead of
class-based, although I'm not sure if that requires to change the fork mode.
> 4.0 quality testing: Read Repair
> --------------------------------
>
> Key: CASSANDRA-15977
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15977
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest/java, Test/unit
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
> This is a subtask of CASSANDRA-15579 focusing on read repair.
> [This
> document|https://docs.google.com/document/d/1-gldHcdLSMRbDhhI8ahs_tPeAZsjurjXr38xABVjWHE/edit?usp=sharing]
> lists and describes the existing functional tests for read repair, so we can
> have a broad view of what is currently covered. We can comment on this
> document and add ideas for new cases/tests, so it can gradually evolve to a
> more or less detailed test plan.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
