[
https://issues.apache.org/jira/browse/CASSANDRA-16200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243738#comment-17243738
]
Berenguer Blasi commented on CASSANDRA-16200:
---------------------------------------------
Hi [~dcapwell],
bq. made the change to no longer touch stdout in nodetool, what are the cases
you see touching stdout? This looks more like a bug, so shouldn't try to work
around it
Sorry not following, can you eli5 please? changes to not touch stdout? What
bug? I only added a unit test to test that nodetool command.
bq. Also saw that we added the following to
src/java/org/apache/cassandra/tools/nodetool/Ring.java
Iirc there was either a NPE or some other sort of obvious failure when running
the command bc IPs where reaching us here with a '/'. I chased down the code
deep and we seem to have code sometimes render them with the '/' and sometimes
without it. That gets pushed into data structures across the code where lookups
have to match the '/' presence or absence. Here we had to remove the '/' for
the lookup to work. It's should be easy to repro by removing that line and
running the test.
I don't think that affects output as that IP is not printed, just used for a
lookup for tokens as per the code. I guess that didn't get picked up by Jon bc
the test didn't exist back then?
> Nodetool ring unit testing
> --------------------------
>
> Key: CASSANDRA-16200
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16200
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-beta3
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Add nodetool ring testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
