[
https://issues.apache.org/jira/browse/CASSANDRA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285690#comment-17285690
]
Jacek Lewandowski commented on CASSANDRA-16415:
-----------------------------------------------
thank you [~yifanc] for reviewing
All in all, I don't think messaging version change would help there. The
problem is that we need to know the version upfront, when executing query
locally. We do not know the version yet, because we do not know which replicas
are going to be queried. On the other hand, I suppose that when we choose a
node as a replica we want to query, we probably already have its endpoint state
data populated, thus its version too (though, I'm not sure, I haven't followed
the code carefully).
If it was just a messaging version, I could imagine that (since 4.0 is not yet
released) we introduced a new version in 3.11 patch release and just
incremented the messaging version in 4.0. This way we would fix it properly for
3.0 -> 3.11.new and for 3.11.new -> 4.0.
I'm going to fix that unit test mentioned by [~adelapena]. I don't think it
will be just a unit test fix, I suppose it will be a change in production code
:/
> Broken test mixedModeReadColumnSubsetDigestCheck -
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16415
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16415
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination, Test/dtest/java
> Reporter: Yifan Cai
> Assignee: Jacek Lewandowski
> Priority: Normal
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The test has been failing and can always be reproduced in the recent CI.
> Stack trace:
> {code:java}
> junit.framework.AssertionFailedError: Found Digest Mismatch
> at
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.checkTraceForDigestMismatch(MixedModeReadTest.java:89)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.lambda$mixedModeReadColumnSubsetDigestCheck$0(MixedModeReadTest.java:63)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:171)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck(MixedModeReadTest.java:76)
> {code}
> The initial investigation shows that
> * The test only fails in the setup phase of
> mixedModeReadColumnSubsetDigestCheck. The cluster version is
> *Versions.Major.v3X*
> * The test failure is likely a consequence of CASSANDRA-15962. After
> dropping the commit in branch cassandra-3.11 and rebuild the dtest jar, the
> upgrade test can pass. Meanwhile, dropping the other commits does not help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
