[ 
https://issues.apache.org/jira/browse/CASSANDRA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291689#comment-17291689
 ] 

Andres de la Peña commented on CASSANDRA-16415:
-----------------------------------------------

Thanks for the changes. There are still a few unneeded {{throws Exception}} on 
the column filter test for 3.11 and trunk that I can easily remove on commit, 
if that's ok for you. Other than this nit the changes look good to me.

It seems that the runs in ci-cassandra above took longer than usual which I 
think can produce some test failures, I have re-run those runs:
 * [ci-cassandra 
3.0|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/418/pipeline]
 * [ci-cassandra 
3.11|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/417/pipeline]
 * [ci-cassandra 
trunk|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/416/pipeline]

Curiously it seems that for 3.11 the tests 
{{SASIIndexTest#testIndexRedistribution/testPagination}} fail consistently, 
when they were occasionally flaky without the patch. Nevertheless the flakiness 
of these tests is being addressed in CASSANDRA-16444 so I think it's safe to 
consider the failures as not related.

[~yifanc] if the CI results above look good to you I can proceed to commit.

> Broken test mixedModeReadColumnSubsetDigestCheck - 
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16415
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16415
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Coordination, Test/dtest/java
>            Reporter: Yifan Cai
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>             Fix For: 3.11.x, 4.0-beta
>
>          Time Spent: 8h 40m
>  Remaining Estimate: 0h
>
> The test has been failing and can always be reproduced in the recent CI. 
> Stack trace: 
> {code:java}
> junit.framework.AssertionFailedError: Found Digest Mismatch
>  at 
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.checkTraceForDigestMismatch(MixedModeReadTest.java:89)
>  at 
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.lambda$mixedModeReadColumnSubsetDigestCheck$0(MixedModeReadTest.java:63)
>  at 
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:171)
>  at 
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck(MixedModeReadTest.java:76)
>  {code}
> The initial investigation shows that 
>  * The test only fails in the setup phase of 
> mixedModeReadColumnSubsetDigestCheck. The cluster version is 
> *Versions.Major.v3X*
>  * The test failure is likely a consequence of CASSANDRA-15962. After 
> dropping the commit in branch cassandra-3.11 and rebuild the dtest jar, the 
> upgrade test can pass. Meanwhile, dropping the other commits does not help. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to