[ 
https://issues.apache.org/jira/browse/CASSANDRA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291782#comment-17291782
 ] 

Yifan Cai commented on CASSANDRA-16415:
---------------------------------------

Thanks for running the test!

The test failures from [ci-cassandra 
3.0|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/418/pipeline]
 do not look related.

The test failures from [ci-cassandra 
3.11|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/417/pipeline]
 do not look related. The test 
{{SASIIndexTest#testIndexRedistribution/testPagination}} does not touch the 
{{ColumnFilter.Serializer#deserialize}} code path.

The test failures from [ci-cassandra 
trunk|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/416/pipeline]
 mostly look unrelated. There is one failure I need to point out, 
{{mixedModeReadColumnSubsetDigestCheck – 
org.apache.cassandra.distributed.upgrade.MixedModeReadTest}}. However, it 
cannot be reproduced by running the test repeatedly on my local. The dtest jars 
were built from all 3 patched branches. I think Jenkins built the v30/v3x jvm 
dtest jars from HEAD instead of the patched branches, which explains the 
failure.

So, +1 on proceed to commit.

Beside, I'd *strongly* suggest to update the title of the ticket, so it 
provides more clarity on what is the problem the patch to solve. As mentioned 
in the earlier comment, it is not just fixing the broken test.

> Broken test mixedModeReadColumnSubsetDigestCheck - 
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16415
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16415
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Coordination, Test/dtest/java
>            Reporter: Yifan Cai
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>             Fix For: 3.11.x, 4.0-beta
>
>          Time Spent: 8h 40m
>  Remaining Estimate: 0h
>
> The test has been failing and can always be reproduced in the recent CI. 
> Stack trace: 
> {code:java}
> junit.framework.AssertionFailedError: Found Digest Mismatch
>  at 
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.checkTraceForDigestMismatch(MixedModeReadTest.java:89)
>  at 
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.lambda$mixedModeReadColumnSubsetDigestCheck$0(MixedModeReadTest.java:63)
>  at 
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:171)
>  at 
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck(MixedModeReadTest.java:76)
>  {code}
> The initial investigation shows that 
>  * The test only fails in the setup phase of 
> mixedModeReadColumnSubsetDigestCheck. The cluster version is 
> *Versions.Major.v3X*
>  * The test failure is likely a consequence of CASSANDRA-15962. After 
> dropping the commit in branch cassandra-3.11 and rebuild the dtest jar, the 
> upgrade test can pass. Meanwhile, dropping the other commits does not help. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to