[
https://issues.apache.org/jira/browse/CASSANDRA-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048946#comment-13048946
]
Alan Liang commented on CASSANDRA-2629:
---------------------------------------
CompactionManager.java:
-retrying from key/length from index is useful, we should add this back, as
you mentioned in your comments above.
-move "long rowSizeFromIndex = nextRowPositionFromIndex -
currentRowPositionFromIndex;" into the IF statement where it is needed
-in your log warnings, specifying the actual sstable will help with
debugging
SSTableNamesIterator.java:
-remove "this.key = key;" for both constructors and that means "public
DecoratedKey key;" can still be final
*init() method should be more descriptive
-remove @param key comment from IFilter.java and
SSTableSliceIterator.java
SSTableWriter.java:
-calling close() on an SSTableIdentityIterator to go to the end doesn't
sound right. Use another name other than "close()"
-safer to updateCache(iter) AFTER appending to writer
> Move key reads into SSTableIterators
> ------------------------------------
>
> Key: CASSANDRA-2629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2629
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 1.0
>
> Attachments:
> 0001-CASSANDRA-2629-Move-key-and-row-size-reading-into-the-.txt,
> 0002-CASSANDRA-2629-Remove-the-retry-with-key-from-index-st.txt
>
>
> All SSTableIterators have a constructor that assumes the key and length has
> already been parsed. Moving this logic inside the iterator will improve
> symmetry and allow the file format to change without iterator consumers
> knowing it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
