[ 
https://issues.apache.org/jira/browse/CASSANDRA-16500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302444#comment-17302444
 ] 

Andres de la Peña commented on CASSANDRA-16500:
-----------------------------------------------

Last changes look good to me. 
[Here|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/487/pipeline]
 is a ci-cassandra run, it would be good to have a CircleCI run as well.

> Missing validation in AbstractType.writeValue():
> ------------------------------------------------
>
>                 Key: CASSANDRA-16500
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16500
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Other
>            Reporter: Benjamin Lerer
>            Assignee: Alexandre Dutra
>            Priority: Normal
>             Fix For: 4.0-rc
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Some validation checks present in {{AbstractType.writeValue()}} in 
> {{cassandra-3.11}} are not there in {{trunk}}.
> In 3.11 the checks used assertion. It would make sense to use 
> {{IOExceptions}} instead as used in   {{AbstractType.readValue()}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to