[
https://issues.apache.org/jira/browse/CASSANDRA-16500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302954#comment-17302954
]
Alexandre Dutra commented on CASSANDRA-16500:
---------------------------------------------
Thank you both for the thorough reviews. I cherry-picked Andrés' commit and
also fixed {{ScrubTest.testScrubColumnValidation}} manually (it wasn't possible
to cherry-pick). Let's see how this goes with CI.
> Missing validation in AbstractType.writeValue():
> ------------------------------------------------
>
> Key: CASSANDRA-16500
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16500
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
> Reporter: Benjamin Lerer
> Assignee: Alexandre Dutra
> Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Some validation checks present in {{AbstractType.writeValue()}} in
> {{cassandra-3.11}} are not there in {{trunk}}.
> In 3.11 the checks used assertion. It would make sense to use
> {{IOExceptions}} instead as used in {{AbstractType.readValue()}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
