[
https://issues.apache.org/jira/browse/CASSANDRA-16500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299589#comment-17299589
]
Andres de la Peña commented on CASSANDRA-16500:
-----------------------------------------------
Overall looks good to me, I have left a couple of comments on the PR. Do we
have CirceCI runs for the patch?
> Missing validation in AbstractType.writeValue():
> ------------------------------------------------
>
> Key: CASSANDRA-16500
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16500
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
> Reporter: Benjamin Lerer
> Assignee: Alexandre Dutra
> Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Some validation checks present in {{AbstractType.writeValue()}} in
> {{cassandra-3.11}} are not there in {{trunk}}.
> In 3.11 the checks used assertion. It would make sense to use
> {{IOExceptions}} instead as used in {{AbstractType.readValue()}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
