[
https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331301#comment-17331301
]
Michael Semb Wever commented on CASSANDRA-16629:
------------------------------------------------
[~azotcsit], thanks for the work.
some feedback…
1. sounds good.
2. only to be applied where the patch already touches. (there shouldn't be
files in the patch that only consist of formatting changes)
3. the project's only consensus so far has been to favour assertj (see this [ML
thread|https://lists.apache.org/thread.html/rc562ec47578d0ae6f346ba9e3d7469c1cd3f8b521a72ddcb2accc47b%40%3Cdev.cassandra.apache.org%3E])
4. same as (2)
I'm curious if we want to apply a patch to all branches. it's not much fun on
code that's unnecessarily changed between branches when forward-merging.
> Rafactor tests for NodeTool commands
> ------------------------------------
>
> Key: CASSANDRA-16629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16629
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Alexey Zotov
> Assignee: Alexey Zotov
> Priority: Normal
> Fix For: 4.0.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> h3. Overview
> As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for
> invalidation of the auth caches. While working on that, I've mentioned that
> the existing NodeTool unit tests are written in a different manner and reside
> in wrong packages. I've made the following changes to them:
> # moved them to the proper packages (that match original command class)
> # unified naming, formatting, imports
> # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is
> not smth really required)
> # made a general cleanup
> PR: https://github.com/apache/cassandra/pull/982
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
