[
https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331318#comment-17331318
]
Alexey Zotov commented on CASSANDRA-16629:
------------------------------------------
[~mck]
thanks for the quick response!
2,4. ok, I've rolled back some changes in a separate
[commit|https://github.com/apache/cassandra/pull/982/commits/655036bcc2b10a0133892a0a99f0e83cd3c23651].
I still feel they would be useful and safe, so if you check the commit and
find them good to go, please, let me know and I'll bring them back.
3. hmm.. actually that Slack communication was mine. And what I understood is
that there is no preference on one library over the other:
{quote}Thats test author dependent; some know different libs more than others.
The main question is how readable your tests are.{quote}
should I migrate tests to assertj? I have no problems with doing that since it
is smth hard or time consuming.
{quote}I'm curious if we want to apply a patch to all branches. it's not much
fun on code that's unnecessarily changed between branches when
forward-merging.{quote}
I think it is makes sense to apply the code to all branches. I do not expect to
see conflicts with these changes, so it should be fairly easy. Anyway, I think
I need to wait until the current changes are reviewed/approved and only after
that start working on backporting. Here are a few general questions on the
process:
5. What branches should I backport these changes to? Should I create separate
PRs for every branch? Is there anything specific I should know?
> Rafactor tests for NodeTool commands
> ------------------------------------
>
> Key: CASSANDRA-16629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16629
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Alexey Zotov
> Assignee: Alexey Zotov
> Priority: Normal
> Fix For: 4.0.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> h3. Overview
> As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for
> invalidation of the auth caches. While working on that, I've mentioned that
> the existing NodeTool unit tests are written in a different manner and reside
> in wrong packages. I've made the following changes to them:
> # moved them to the proper packages (that match original command class)
> # unified naming, formatting, imports
> # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is
> not smth really required)
> # made a general cleanup
> PR: https://github.com/apache/cassandra/pull/982
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
