[
https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331437#comment-17331437
]
Michael Semb Wever commented on CASSANDRA-16629:
------------------------------------------------
bq. should I migrate tests to assertj?
The tests, and asserts, you add you can choose. Taking onboard the project is
leaning towards the precedence of assertj. Generally we don't rewrite existing
asserts unless we are editing that code already. (Reviewers are limited on time
so we make patches as minimal to the scope as possible.)
bq. I think I need to wait until the current changes are reviewed/approved and
only after that start working on backporting
You are spot on 😀
Once you have confirmation on one patch, a patch for each branch is required.
You don't need to create the PR, we can view the patch via the github "compare"
page, and add comments on the github commit page if that's needed.
This will be applicable to 2.2, 3.0, 3.11 and trunk.
> Rafactor tests for NodeTool commands
> ------------------------------------
>
> Key: CASSANDRA-16629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16629
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Alexey Zotov
> Assignee: Alexey Zotov
> Priority: Normal
> Fix For: 4.0.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> h3. Overview
> As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for
> invalidation of the auth caches. While working on that, I've mentioned that
> the existing NodeTool unit tests are written in a different manner and reside
> in wrong packages. I've made the following changes to them:
> # moved them to the proper packages (that match original command class)
> # unified naming, formatting, imports
> # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is
> not smth really required)
> # made a general cleanup
> PR: https://github.com/apache/cassandra/pull/982
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
