[
https://issues.apache.org/jira/browse/CASSANDRA-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401077#comment-17401077
]
Ekaterina Dimitrova commented on CASSANDRA-16725:
-------------------------------------------------
{quote}If reviewers have become involved, always try to keep them included and
take some patience for them to wrap up with a formal +1 on the ticket. This is
important to create a warm and inclusive culture here. Ideally reviewers should
remove themselves from the list if they see that they won't be returning to
provide such a +1.
{quote}
+1. I think of the rule for two committers +1 as a minimum requirement for a
commit to happen. BUT if there are more people who were trying to help with a
review, it is a respect to their time and effort to wait for them to either
finish it or signal that they are fine the patch to be committed without their
final vote. Also, it doesn't matter whether it is contributor, committer or
PMC. Every review matters. How I see reviews is they are the belief of a person
that a work Is meaningful and he/she supports It through dedicating time and
efforts into helping to shape it/provide feedback.
{quote}I think they _are_ ironed out as of now after the very last round from
Ekaterina so you might indeed take a look too now.
{quote}
+1, just please add a comment (or maybe even better, java doc) on commit about
that method to make it easier to find and understand its goal by whoever needs
it/looks at it. Thank you for all your work!
> Implement nodetool getauditlog command
> --------------------------------------
>
> Key: CASSANDRA-16725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16725
> Project: Cassandra
> Issue Type: New Feature
> Components: Tool/auditlogging
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.1
>
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> There is getfullquerylog already, there is not any reason why getauditlog
> should not be there too. A user can not retrieve runtime configuration of
> Audit log, it might be only enabled and disabled via jmx but its state can
> not be queried in runtime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
