[ 
https://issues.apache.org/jira/browse/CASSANDRA-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401280#comment-17401280
 ] 

Ekaterina Dimitrova commented on CASSANDRA-16725:
-------------------------------------------------

My only point was that I am with Mick on this - "_Ideally reviewers should 
remove themselves from the list if they see that they won't be returning to 
provide such a +1_"

I have one question for you, are you going to add the person as a reviewer?  To 
me both "yes" and "no" doesn't feel good.
 # in case of a "yes" - someone is merit without doing the job maybe or a 
critical bug appears and people think that this person approved the buggy 
code... (unfortunately, sometimes things happen, distributed systems are 
complex)
 # in case of a "no" - the person put some time and efforts and maybe they were 
even doing  still something in the background but you didn't know and you just 
skipped them. It's not about being adult in this case I think.

Also, please, consider that many of the engineers in the community come with 
different background and are experts in different areas of the codebase so it 
is possible to get the best of all worlds if you hear more people. :) As a wise 
man once said ([~mck] :)) - "The beauty of OSS is in the teamwork"

One more time, thank you for all the great work! I think this work will be 
really appreciated by our users. 

> Implement nodetool getauditlog command
> --------------------------------------
>
>                 Key: CASSANDRA-16725
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16725
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tool/auditlogging
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.1
>
>          Time Spent: 15h 10m
>  Remaining Estimate: 0h
>
> There is getfullquerylog already, there is not any reason why getauditlog 
> should not be there too. A user can not retrieve runtime configuration of 
> Audit log, it might be only enabled and disabled via jmx but its state can 
> not be queried in runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to